[TRTLLM-15076][test] Remove Bielik-11B-v2.2-Instruct an… - #17345
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe PR removes Kanana accuracy coverage and Bielik model-path, performance, and multi-LoRA test coverage from integration and unit test definitions. ChangesModel test coverage removal
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run |
|
PR_Github #64254 [ run ] triggered by Bot. Commit: |
|
PR_Github #64254 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #64338 [ run ] triggered by Bot. Commit: |
|
PR_Github #64338 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #64475 [ run ] triggered by Bot. Commit: |
|
PR_Github #64475 [ run ] completed with state |
zhaoyangwang-nvidia
left a comment
There was a problem hiding this comment.
Cleanup looks complete — no leftover references, no unused imports, CI green. One question below.
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
…d kanana-1.5-2.1b-instruct-2505 tests Remove all test cases, test list entries, model path registrations, accuracy references, and waives for these two models. Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
|
/bot reuse-pipeline |
|
PR_Github #65486 [ reuse-pipeline ] triggered by Bot. Commit: |
|
PR_Github #65486 [ reuse-pipeline ] completed with state |
…d kanana-1.5-2.1b-instruct-2505 tests
Remove all test cases, test list entries, model path registrations, accuracy references, and waives for these two models.
Dev Engineer Review
QA Engineer Review
TestKanana_Instruct::test_auto_dtypeand its MMLU and GSM8K accuracy coverage.qa/llm_function_core.txtandwaives.txt.test_bielik_11b_v2_2_instruct_multi_lora.test-db/l0_perf.yml.Description
The background is https://docs.google.com/spreadsheets/d/17qLRr5oQESqn1rT9LrIUnpjvhH8wcC59273YEPT9k44/edit?gid=177162358#gid=177162358
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.