Skip to content

[TRTLLM-15076][test] Remove Bielik-11B-v2.2-Instruct an… - #17345

Merged
xinhe-nv merged 1 commit into
NVIDIA:mainfrom
xinhe-nv:prune
Aug 12, 2026
Merged

[TRTLLM-15076][test] Remove Bielik-11B-v2.2-Instruct an…#17345
xinhe-nv merged 1 commit into
NVIDIA:mainfrom
xinhe-nv:prune

Conversation

@xinhe-nv

@xinhe-nv xinhe-nv commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

…d kanana-1.5-2.1b-instruct-2505 tests

Remove all test cases, test list entries, model path registrations, accuracy references, and waives for these two models.

Dev Engineer Review

  • Removed Bielik-11B-v2.2-Instruct test, performance, model path, and multi-LoRA references.
  • Removed Kanana accuracy references, test entries, and waiver entry.
  • Configuration and test-list changes match the removal scope.
  • No production-code or API changes are included.

QA Engineer Review

  • Removed TestKanana_Instruct::test_auto_dtype and its MMLU and GSM8K accuracy coverage.
  • Removed the Kanana test from qa/llm_function_core.txt and waives.txt.
  • Removed test_bielik_11b_v2_2_instruct_multi_lora.
  • Removed the Bielik performance entry from test-db/l0_perf.yml.
  • Removed the Bielik model path registration.
  • The Kanana test was covered in the QA test list.
  • The Bielik multi-LoRA test was not listed in the modified integration test lists.
  • Verdict: sufficient.

Description

The background is https://docs.google.com/spreadsheets/d/17qLRr5oQESqn1rT9LrIUnpjvhH8wcC59273YEPT9k44/edit?gid=177162358#gid=177162358

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

The PR removes Kanana accuracy coverage and Bielik model-path, performance, and multi-LoRA test coverage from integration and unit test definitions.

Changes

Model test coverage removal

Layer / File(s) Summary
Kanana accuracy coverage removal
tests/integration/defs/accuracy/references/*.yaml, tests/integration/defs/accuracy/test_llm_api_pytorch.py, tests/integration/test_lists/qa/llm_function_core.txt
Removes Kanana GSM8K and MMLU references, the PyTorch accuracy test, and its test-list entry.
Bielik test coverage removal
tests/integration/defs/perf/_model_paths.py, tests/integration/test_lists/test-db/l0_perf.yml, tests/unittest/llmapi/test_llm_pytorch.py
Removes the Bielik model path, L40S performance configuration, and multi-LoRA unit test.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: qijune, chenfeiz0326, ruodil

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title identifies the ticket, test scope, and removal of the Bielik model, which is a major change in the pull request.
Description check ✅ Passed The description explains the removal scope and provides background, but the Test Coverage section is empty and most checklist items are unconfirmed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@xinhe-nv

xinhe-nv commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64254 [ run ] triggered by Bot. Commit: d9bc9b6 Link to invocation

Comment thread tests/integration/defs/accuracy/test_llm_api_pytorch.py
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64254 [ run ] completed with state FAILURE. Commit: d9bc9b6
/LLM/main/L0_MergeRequest_PR pipeline #52159 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@xinhe-nv

xinhe-nv commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64338 [ run ] triggered by Bot. Commit: 7300624 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64338 [ run ] completed with state ABORTED. Commit: 7300624

Link to invocation

@xinhe-nv

xinhe-nv commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64475 [ run ] triggered by Bot. Commit: 7300624 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64475 [ run ] completed with state SUCCESS. Commit: 7300624
/LLM/main/L0_MergeRequest_PR pipeline #52349 completed with status: 'SUCCESS'

CI Report

Link to invocation

@zhaoyangwang-nvidia zhaoyangwang-nvidia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup looks complete — no leftover references, no unused imports, CI green. One question below.

Comment thread tests/integration/defs/accuracy/test_llm_api_pytorch.py
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

…d kanana-1.5-2.1b-instruct-2505 tests

Remove all test cases, test list entries, model path registrations, accuracy
references, and waives for these two models.

Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv

Copy link
Copy Markdown
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65486 [ reuse-pipeline ] triggered by Bot. Commit: 4a8be88 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65486 [ reuse-pipeline ] completed with state SUCCESS. Commit: 4a8be88
Reusing PR_Github #64475 for commit 4a8be88

Link to invocation

@xinhe-nv
xinhe-nv merged commit 7a7f957 into NVIDIA:main Aug 12, 2026
7 checks passed
@xinhe-nv
xinhe-nv deleted the prune branch August 12, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants